<div class="quote"><i>Sinthorion wrote:
<div class="quote">MilkMC wrote:
The initial tests that I did were in 26.5. Now I have updated to 27.0, and the Rohirrim NPC no longer allows custom weapon selection. In general, good NPCs don't allow custom weapon selection, while evil NPCs do (though there are probably a few exceptions to this). Everything else seems to behave the same.</i></div>
Is it also fixed for evil NPCs? They eat too. </div> Nothing got fixed, it got worse. In beta 26.5, I was able to put anything I wanted in the hand of a Rohirrim, but now, (in beta 27.0) if I try to put something in its hand, it simply disappears right away. I can put anything I want in the hand of an orc, but if I try to put something in the hand of an NPC classed as men, elves, or dwarves, (exceptions: Rhudaur, Dunland, and Bandit NPCs)  it disappears. As stated above, a GondorArcher will still shoot arrows even though visually there is nothing in its hand. Interestingly enough, a BarrowWight will appear to hold the item, but does not drop it upon death, even though it should. Anyway, here is a picture of the TauredainWarrior holding nothing in its hand. It was summoned using the original command. <figure class="article-thumb tright show-info-icon" style="width: 180px"> <figcaption> <p class="caption">Tauredain Warrior</p> </figcaption></figure><p>
</p><p>Also I tried to see if the command would work on traveling traders, but unfortunately they leave the area as soon as they are summoned. I'm not sure if this is intentional or not. </p>

<p>Is this still a mystery? I can provide details on the 'new' weapon NBT format if needed, so someone can document it somewhere. </p>

is it?

<div class="quote"><i> <p>LOTRMod wrote: Is this still a mystery? I can provide details on the 'new' weapon NBT format if needed, so someone can document it somewhere. </p> </i></div>
<p>That would be great if you could do that. I will also try going back further than beta 26.5 (When I have the time) and see if it worked in previous versions. </p><p> <span style="background-color:#000000; border-radius:5px; border:3px ridge #3333ff"> <font color="#FFFFFF"> MilkMC</font> ^{<font color="#FFFFFF">Send me a message, <span class="insertusername">Fandom User</span>.</font>}</span> </p>

<p>Alright, I'll start with an explanation of what the new weapon format actually is. Warning: long post ahead! </p><p>The vanilla equipment format only saves one held item. Since many of the LOTR NPCs switch between melee and ranged combat, they need to be able to store separate melee and ranged items. In the old days this was done by just specifying the melee/ranged weapons statically in the NPC's class file. But this wasn't ideal, because it meant they could only ever have one possible melee weapon and one ranged weapon - rather than one weapon selected from a range of possibilities and then saved specifically with that NPC, like e.g. Orcs with their various possible melee weapons. </p><p>This also meant that you couldn't use commands to summon a melee-ranged-switching NPC with a particular melee or ranged weapon. And in addition, some NPCs started to be designed with 'idle items' in addition to their melee and ranged weapons - these idle items again had to be hard-coded, and even giving an NPC 'nothing' as its idle item meant that it could no longer have a specific saved melee weapon, only a statically-coded one, for the same reason as above - because the vanilla format only saves one held item. </p><p>So to fix these problems and avoid having to reuse code I designed a new unified storage format that has slots for several held items in many different circumstances. In this new format, idle items, melee weapons, etc. are saved persistently for each NPC, and the NPC takes a copy of these saved items and places it in the vanilla 'held item' slot depending on the circumstances. </p><p>The slots, their numbers (used in commands), and their names (referenced in the code, but not used in commands) are: </p><p>0: 'IDLE_ITEM': an item to be held when not in combat. </p><p>1: 'WEAPON_MELEE': an item to be held in melee combat. </p><p>2: 'WEAPON_RANGED': for ranged combat. </p><p>3: 'SPEAR_BACKUP': if this slot is nonempty, then when the NPC has a spear in its melee slot, it will throw the spear and then move SPEAR_BACKUP into WEAPON_MELEE as the new melee weapon and clear SPEAR_BACKUP. If this slot is empty, then the NPC will use any spear in its melee slot as an ordinary melee weapon. </p><p>This is used for NPCs who can spawn with spears, so that they have an additional fallback melee weapon to use after throwing the spear. In the old days of the mod the spear backup item was also hard-coded for every NPC type. </p><p>4: 'EATING_BACKUP': when the NPC starts to eat, drink, or smoke, it will move its current held item into this slot. Once it's finished consuming, it will re-equip the eating backup. </p><p>5: 'IDLE_ITEM_MOUNTED': an item to be held when the NPC is mounted, and idle. </p><p>6: 'WEAPON_MELEE_MOUNTED': as above, with melee combat. </p><p>7: 'REPLACED_IDLE': if you give a hired unit a new melee weapon, that new weapon overrides the default idle item. The idle item is saved in this slot, to be restored if you choose to retake the replacement weapon back from the NPC. </p><p>8: 'REPLACED_MELEE_MOUNTED': as above, for a melee mounted item. </p><p>9: 'REPLACED_IDLE_MOUNTED': as above, for an idle mounted item. </p><p>10: 'BOMBING_ITEM': for Orcs, an item to be held in the right hand while using bombardier AI. </p><p>11: 'BOMB': for Orcs, the actual bomb item to be held in the left hand, which determines the strength of the bomb that will be placed. The presence or absence of an item in this slot determines whether bombardier AI or normal melee AI is used. </p><p>An important caveat is that the implementation of this storage system depends on the NPC. Many NPCs will only make use of the idle and melee slots, and have no ranged AI, so putting something in the ranged slot with commands will not make them capable of using ranged combat. Likewise, most NPCs do not use the specific mounted slots. These are only used by some NPCs, such as the Gondor Soldier, who can use lances on horseback but switch to a sword, dagger, etc. if their mount is killed. </p><p>Now, an example of how to use these in commands: </p><p>/summon lotr.GondorSoldier ~ ~ ~ {Equipment:[{},{id:4225},{id:4224},{id:4223},{id:4222}],NPCItemsInv:[{Slot:0,id:4102},{Slot:1,id:4261},{Slot:2,id:4180}]} </p><p>This summons a Gondor Soldier wearing dwarven armour, with a mithril ingot as his idle item, a troll bone as his melee weapon, and a mallorn bow as his ranged weapon. Note the 'NPCItemsInv' tag, and the 'Slot:0' with 0 corresponding to 'IDLE_ITEM', the 'Slot:1' corresponding to WEAPON_MELEE, and the 'Slot:2' corresponding to WEAPON_RANGED. (This is only a melee user, but the ranged weapon is included for the sake of example. To actually see the custom bow in action you would need to summon a lotr.GondorArcher instead.) </p><p>Warning: Item IDs will very possibly vary between worlds, so I would advise you to check using F3+H what the IDs of your world's items are. </p><p>But wait! That's not all! There is also the hired replaced items inventory. This works similarly to the normal NPC items inventory, but it is specialised for hired unit equipment replacement, to save the previously-equipped items so that the unit can re-equip them if you take back the replacement item. This inventory has the NBT tag 'HiredReplacedItems' instead of 'NPCItemsInv' and the following slots: </p><p>0: 'HELMET': the helmet the unit was previously wearing, before you gave it a new one. If you take the replacement helmet back, it will wear the item in this slot again. </p><p>1: 'BODY': as above, for a chestplate. </p><p>2: 'LEGS': for leggings, </p><p>3: 'BOOTS': for boots. </p><p>4: 'MELEE': for a melee weapon. </p><p>5: 'BOMB': for an Orc bomb. </p><p>6: 'RANGED': for a ranged weapon. (Not yet implemented.) </p><p>Now, if you were paying attention through all that, you may wonder why the REPLACED_IDLE and REPLACED_MELEE_MOUNTED and REPLACED_IDLE_MOUNTED slots are in the NPCItemsInv, instead of the HiredReplacedItems where they would seem to belong. The answer: the equipment replacement screen has no inventory slots for idle items, mounted melee weapons, or mounted idle items. Only those replaced items which have corresponding GUI-inventory slots are in the HiredReplacedItems - which makes it much simpler to associate to an actual GUI-inventory - and the other replaced items are stored in the unseen NPCItemsInv. </p><p>I can't imagine why anyone would ever want to use the HiredReplacedItems in commands, unless they are designing a very specific scenario where you meet an already-hired unit and have to relieve him of his weapons and armour and discover that he is actually wearing mithril underneath, or something bizarre. </p>

<p><i>LOTRMod wrote: ... long post ahead! ...</i> </p><p>Wow, what a lot of information, thank you for telling us! This seems to be quite valuable for working into the wiki pages as well. </p><p>With all that stuff, NPC mechanics got quite flexible and powerful, and probably more difficult to implement. Perhaps also more prone to bugs? </p><p>Edit: I just noticed, that the first post of user:LOTRMod was a necro post, but in this case, I hope all moderators will agree, we can ignore it. Or shall we kick the creator of the Mod out of his own wiki for violating the forum rules if we are able to do this at all? </p> <div style="text-align:center; background-color:#3caa25; border:2px ridge green; width:18em">   <font color="#cebc1e"><span title="Ffets">ᚠᚠᛖᛏᛋ (ContentMod)</span></font>   </div>

<div class="quote"><i>Ffets wrote: <p>Edit: I just noticed, that the first post of user:LOTRMod was a necro post, but in this case, I hope all moderators will agree, we can ignore it. Or shall we kick the creator of the Mod out of his own wiki for violating the forum rules if we are able to do this at all? </p> <div style="text-align:center; background-color:#3caa25; border:2px ridge green; width:18em">   <font color="#cebc1e"><span title="Ffets">ᚠᚠᛖᛏᛋ (ContentMod)</span></font>   </i></div>

</div> <p>The thread was not resolved; it was sleeping. LOTRMod made a <i>somni</i>post, not a necropost ;)
</p><p>
</p>

<p><i>Sinthorion wrote: ... a somnipost, not a necropost ...</i> </p><p>Although, it's an euphemism, it's also an elegant way out of this dilemma. Thanks Sinth. </p> <div style="text-align:center; background-color:#3caa25; border:2px ridge green; width:18em">   <font color="#cebc1e"><span title="Ffets">ᚠᚠᛖᛏᛋ (ContentMod)</span></font>   </div>

<p><span style="font-family:monospace;font-size:14px;font-weight:normal;">/summon lotr.GondorSoldier ~ ~ ~ {Equipment:[{},{id:4225},{id:4224},{id:4223},{id:4222}],NPCItemsInv:[{Slot:0,id:4102},{Slot:1,id:4261},{Slot:2,id:4180}]} Isn't working for me anymore :P (It spawns Gondor Soldier without armor and weapon)</span> </p>

<p>Your ids are likely different than those listed. Change the ids so that each one corresponds to the appropriate item. </p><p>I will now be closing this due to necroposting. </p><p> <span style="background-color:#000000; border-radius:5px; border:3px ridge #3333ff"> <font color="#FFFFFF"> MilkMC</font> ^{<font color="#FFFFFF">Check your render distance, <span class="insertusername">Fandom User</span>!</font>}</span> </p>